etcdctl txn needs two trailing newlines on stdin

and make sure to check the returncode
jupyterhub · Mar 6, 2023 · 174be9a · 174be9a
1 parent b4f9780
commit 174be9a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -393,8 +393,12 @@ def _config_etcd(*extra_args):
     proc = subprocess.Popen(
         data_store_cmd, stdin=subprocess.PIPE, env=Config.etcdctl_env
     )
-    proc.communicate(txns.encode())
+    # need two trailing newlines for etcdctl txn to complete
+    proc.communicate(txns.encode() + b'\n\n')
     proc.wait()
+    assert (
+        proc.returncode == 0
+    ), f"{data_store_cmd} exited with status {proc.returncode}"
 
 
 @pytest.fixture