Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to allow_all True #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Default to allow_all True #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tmpauthenticator/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,17 @@ def _auto_login_default(self):
"""
return True

@default("allow_all")
def _allow_all_default(self):
"""
If no allow config is specified, then by default nobody will have access.
Prior to JupyterHub 5.0, the opposite was true.

Setting allow_all to True to preserve expected behavior of allowing
everyone to access the hub in a JupyterHub 5.0 setup.
"""
return True

login_service = Unicode(
"Automatic Temporary Credentials",
help="""
Expand Down
Loading