Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consolidate lock file handling #994

Merged
merged 2 commits into from
Sep 16, 2024
Merged

consolidate lock file handling #994

merged 2 commits into from
Sep 16, 2024

Conversation

minrk
Copy link
Member

@minrk minrk commented Sep 5, 2024

  • makes filelock a dependency of tljh (missing this is the reason for the in-function imports)
  • adds config_file_lock context manager to re-use
  • moves filelock import to module level
  • fixes exit codes, stderr messages

small polish on #976

minrk added 2 commits September 5, 2024 11:58
@minrk
consolidate lock file handling
13c8946 
- adds config_file_lock context manager to re-use
- moves filelock import to module level
- fixes exit codes, stderr messages
@minrk
filelock is a dependency of tljh
0c32277
@jrdnbradford
Copy link
Contributor

So that's what I missed in #976. I kept throwing filelock into requirements files when it should have gone into setup.py. Thanks @minrk.

@consideRatio consideRatio merged commit 7be7eb4 into jupyterhub:main Sep 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minrk @jrdnbradford @consideRatio