Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for 1.0.0b1 #888

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented May 13, 2023

I propose we make a 1.0.0b1 release ~today (July 6th 2023)! I know there are at least a few users very interested in getting a release out based on comments in issues. I'm going on vacation next week, and really hope to have a beta release out by then. I have a lot of other things I need to do by then as well, so I'm extremely thankful for all help to get this pre-release out.

Action points

Action points that maybe doesn't block a 1.0.0b1 release

  • There should ideally be notes to link to from the changelog on how to make an upgrade and what to think about when doing one

Related

Changelog preview

See it at [RTD PR build[(https://the-littlest-jupyterhub--888.org.readthedocs.build/en/888/reference/changelog.html), here is a screenshot.

image

@consideRatio consideRatio marked this pull request as draft May 13, 2023 18:13
@consideRatio consideRatio self-assigned this Jun 8, 2023
@consideRatio consideRatio force-pushed the pr/add-changelog-1.0.0 branch 3 times, most recently from ca1ec43 to ca61caa Compare June 9, 2023 16:33
@consideRatio consideRatio marked this pull request as ready for review June 9, 2023 16:33
@consideRatio consideRatio mentioned this pull request Jun 9, 2023
4 tasks
@consideRatio
Copy link
Member Author

consideRatio commented Jun 9, 2023

Ideas on additional changes before release

  • To add a dedicated section about ugprades (Document upgrade strategy #81)
  • In this changelog, link to the result of that dedicated upgrade section, and/or write in it that one is expected to run the bootstrap.py script as fetched from the internet.
  • Relocate changelog to rendered docs

Copy link
Contributor

@nsurleraux-railnova nsurleraux-railnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! It still needs documentation about the upgrading process, especially about upgrading user env libs and making a backup if the upgrade borks the user env.

@consideRatio
Copy link
Member Author

Thanks for reviewing @nsurleraux-railnova!! ❤️ 🎉

especially about upgrading user env libs and making a backup if the upgrade borks the user env.

When you write "about upgrading user env libs", what are you thinking about more specifically? I'm thinking that this upgrade should not need to be associated with upgrading the user env in any way, and that users should manage that independently on this upgrade being made.

@nsurleraux-railnova
Copy link
Contributor

When you write "about upgrading user env libs", what are you thinking about more specifically? I'm thinking that this upgrade should not need to be associated with upgrading the user env in any way, and that users should manage that independently on this upgrade being made.

In your changelog, you are including a table namedDependency changes in the user environment, which may lead to think that they are part of the automated upgrade process. But the code specifies that they won't be upgraded. I would like to see in the documentation of the upgrade process:

  • Backup your /opt/tljh/user folder.
  • Run /opt/tljh/user/bin/pip install jupyterhub==4.x.x

Or something similar...

Another option could be to have an option in the upgrade process (maybe --upgrade-user-env) that will reinstall the user env dependencies from https://github.com/jupyterhub/the-littlest-jupyterhub/blob/main/tljh/requirements-user-env-extras.txt. It should be pretty clear in the documentation that a backup is always necessary or the upgrade process should automatically backup the user env...

@consideRatio consideRatio changed the title Add changelog for 1.0.0 Add changelog for 1.0.0b1 Jul 5, 2023
@consideRatio consideRatio mentioned this pull request Jul 5, 2023
1 task
@consideRatio consideRatio force-pushed the pr/add-changelog-1.0.0 branch 2 times, most recently from e008f7e to 6ad4b29 Compare July 5, 2023 23:00
@nsurleraux-railnova
Copy link
Contributor

Hi @consideRatio,

Will the first release of 1.0.0 be a beta version since you changed the version tag to 1.0.0b1? What motived this change of direction?

@consideRatio
Copy link
Member Author

@nsurleraux-railnova yes making an initial beta release is the current proposal. I made a proposal for 1.0.0 before because I didn't understand it was technically possible for this project to make make a beta release until yesterday via #909 (comment).

@nsurleraux-railnova
Copy link
Contributor

Ok! Should we then consider this beta as not production ready?

@consideRatio consideRatio force-pushed the pr/add-changelog-1.0.0 branch from 2d9aa6c to bdd0b31 Compare July 7, 2023 16:22
@consideRatio consideRatio merged commit 301f9db into jupyterhub:main Jul 7, 2023
@consideRatio
Copy link
Member Author

Thanks @minrk!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants