Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update awscognito docs to use GenericOAuthenticator #729

Merged
merged 1 commit into from
Oct 24, 2021
Merged

update awscognito docs to use GenericOAuthenticator #729

merged 1 commit into from
Oct 24, 2021

Conversation

minrk
Copy link
Member

@minrk minrk commented Oct 22, 2021

  • Add / update documentation
  • Add tests

closes #540
closes #539

consideRatio
consideRatio approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

Will go for a merge in a day if nobody objects.

@minrk minrk mentioned this pull request Oct 22, 2021
Closed
1 task
minrk
minrk commented Oct 22, 2021
View reviewed changes
docs/howto/auth/awscognito.rst Outdated Show resolved Hide resolved
@consideRatio consideRatio merged commit c6c6e34 into jupyterhub:main Oct 24, 2021
@minrk minrk deleted the awscognito branch October 27, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update oauthenticator to 0.11.0
2 participants
@minrk @consideRatio