Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] adding uninstallation script #134

Closed
wants to merge 1 commit into from

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Aug 13, 2018

  • Add / update documentation
  • Add tests

This PR is meant to add an "uninstall" argument to the tljh-config tool. Here are some open questions:

  1. Can it really delete everything without breaking itself in the middle of deleting things?
  2. Can it delete the JupyterHub without really confusingly breaking someone's session if they're typing from a Jupyter Notebook server terminal (or jupyter lab).
  3. Is the only thing we'd need to delete the /opt/tljh folder?
  4. Should user directories be deleted by default

Depending on the answers to 1 and 2, I may or may not be +1 on this feature being added :-)

closes #128 if it's merged

@yuvipanda
Copy link
Collaborator

Thanks for opening this!

I don't know the answer to (1) :)

Answer to (2) is most definitely shit is gonna fuck up in weird ways.

https://the-littlest-jupyterhub.readthedocs.io/en/latest/topic/installer-actions.html has answers to (3). Short answer is 'a lot more'.

(4) is for sure no.

I'd also like this to be tljh-uninstall, in a file of its own rather than rolled into tljh-config (which should only do configuration related things).

It's also unclear how this should interact with the plugin mechanisms added in #127.

@choldgraf
Copy link
Member Author

I'm gonna close this, because we decided in #128 that it'd be better to capture this use-case with good documentation rather than a one-click solution!

@choldgraf choldgraf closed this Nov 12, 2018
@ptiwari2407
Copy link

@choldgraf , you closed the previous one by pointing to this and now you close this one and pointing to another thread. This is ridiculous. Where is the right solution to uninstall?

@MridulS
Copy link
Collaborator

MridulS commented Aug 16, 2023

https://tljh.jupyter.org/en/latest/topic/installer-actions.html has documentation about reverting the actions of the installation script. If you have a VM, the recommended way is to start with a fresh VM (https://tljh.jupyter.org/en/latest/topic/installer-actions.html#removing-tljh)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a command to uninstall TLJH
4 participants