Skip to content

Add initial repo and code standards #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

manics
Copy link
Member

@manics manics commented Oct 31, 2021

Closes #454

This is the text suggested in #454 (comment) with some minor tweaks.

@welcome

This comment has been minimized.

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manics for nudging this towards resolution and thank you @willingc for writing this draft!

I think this is a good starting point!

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manics.

@willingc willingc merged commit 8d9e96f into jupyterhub:master Nov 2, 2021
@welcome
Copy link

welcome bot commented Nov 2, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@manics manics deleted the code-repo-standards branch November 2, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a section for Team Standards in the team compass
4 participants