Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add triplets for r versions 4.3, 4.4 #1403

Merged
merged 5 commits into from
Feb 20, 2025
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Jan 30, 2025

otherwise r-4.3 won't work

perhaps we should error when a minor version isn't found in the dict (or use x.y.0), because installing R will fail with a 404 trying to download .deb if it's not a 3-part version.

minrk and others added 3 commits February 18, 2025 14:05
otherwise r-4.3 won't work
R.deb download step requires a full x.y.z version, it will 404 on `r-4.4`
Co-authored-by: Simon Li <[email protected]>
@minrk
Copy link
Member Author

minrk commented Feb 19, 2025

Thanks, now fixed and tested

@yuvipanda yuvipanda merged commit 1ad76bc into jupyterhub:main Feb 20, 2025
20 checks passed
@yuvipanda
Copy link
Collaborator

ty @minrk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants