Make tests work with different default branch, or different locale #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, when a user changes the default branch name with
git config --global init.defaultBranch main
the tests would fail.
Setting LANG=C so that on non-English systems, the output of git is consistent.
yuvipanda
reviewed
Nov 11, 2022
|
One suggestion, happy to merge after that, @jdmansour. |
Co-authored-by: Yuvi Panda <[email protected]>
|
Thanks a lot, @jdmansour! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #283. If the user changed the default branch name on their system, the tests would fail.
At the same time, I noticed some tests fail on my laptop with a German OS (LANG=de_DE.UTF-8). This is because we parse the output of
git, which is different if the locale is not set to English. (Now that I think about it, it doesn't just affect the tests and is an actual bug, but I still left it in this PR because it is just a one-liner.)