Don't set a per-build memory limit #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to fix https://jupyter.zulipchat.com/#narrow/channel/469744-jupyterhub/topic/try.20mybinder.20jupyterleab.20demo.20broken, which is breaking because mamba gets OOM killed. We have memory limits set on dind as a whole, and memory_limit for builds (in its current, per-build form) is going away as part of jupyterhub/repo2docker#1402 as well. So let's remove it and see.
yuvipanda
changed the title
yuvipanda
added a commit
to yuvipanda/mybinder.org-deploy
that referenced
this pull request
Feb 8, 2025
Follow-up to jupyterhub#3204, which failed because it removed the limit, which caused it to be lower than the request. All the reasons given in that PR still apply. Here I bump up the limit enough until the super popular https://github.com/jupyterlab/jupyterlab-demo is able to build. It's not a functionally super complex environment.yml, and even with simplifications in jupyterlab/jupyterlab-demo#147, it fails to build without the memory increase limit. As mentioned in the other PR, jupyterhub/repo2docker#1402 will get rid of this kind of limit anyway, so it's ok to raise this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix https://jupyter.zulipchat.com/#narrow/channel/469744-jupyterhub/topic/try.20mybinder.20jupyterleab.20demo.20broken, which is breaking because mamba gets OOM killed. We have memory limits set on dind as a whole, and memory_limit for builds (in its current, per-build form) is going away as part of jupyterhub/repo2docker#1402 as well. So let's remove it and see.
This is a BinderHub version bump. See the link below for a diff of new changes:
https://github.com/jupyterhub/binderhub/compare/...
This is a repo2docker version bump. See the link below for a diff of new changes:
https://github.com/jupyterhub/repo2docker/compare/...