repo2docker: 2021.01.0-7.gac41c20...2021.01.0-11.g1140dd1 #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henchbot
changed the title
|
I think we need to think for a moment before deploying this. I'm worried that we might have changed the name of the docker image we create. If this is true it will be as if we emptied our image cache -> lots of build traffic -> something to do in a quiet moment not during peak traffic (EU afternoon). |
|
If I understand jupyterhub/repo2docker@983607f correctly the image name will only change if Looking at the (presumably most popular) git provider I don't think this is a problem since it's just the SHA |
|
True. So lets merge then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a repo2docker version bump. See the link below for a diff of new changes:
jupyterhub/repo2docker@ac41c20...1140dd1
Associated PRs: