Skip to content

Commit

Permalink
Merge pull request #3205 from jupyterhub/revert-3204-no-mem
Browse files Browse the repository at this point in the history
Revert "Don't set a per-build memory limit"
  • Loading branch information
yuvipanda authored Jan 30, 2025
2 parents b946feb + db15b66 commit e7b2dc8
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions config/hetzner-2i2c-bare.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ binderhub:
# complicated: dind memory request + KubernetesBuildExecutor.memory_request * builds_per_node ~= node memory
KubernetesBuildExecutor:
memory_request: "2G"
memory_limit: "4G"
docker_host: /var/run/dind/docker.sock
repo2docker_extra_args:
# try to avoid timeout pushing to local registry
Expand Down
1 change: 1 addition & 0 deletions config/hetzner-2i2c.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ binderhub:
# complicated: dind memory request + KubernetesBuildExecutor.memory_request * builds_per_node ~= node memory
KubernetesBuildExecutor:
memory_request: "2G"
memory_limit: "4G"
docker_host: /var/run/dind/docker.sock
repo2docker_extra_args:
# try to avoid timeout pushing to local registry
Expand Down
1 change: 1 addition & 0 deletions config/staging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ binderhub:
badge_base_url: https://staging.mybinder.org
image_prefix: us-central1-docker.pkg.dev/binderhub-288415/staging/r2d-2023-04-
sticky_builds: true
build_memory_limit: "2G"
DockerRegistry:
token_url: "https://us-central1-docker.pkg.dev/v2/token"

Expand Down
1 change: 1 addition & 0 deletions mybinder/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ binderhub:
}
KubernetesBuildExecutor:
build_image: quay.io/jupyterhub/repo2docker:2024.07.0-68.gdd097a2
memory_limit: "3G"
memory_request: "1G"

extraConfig:
Expand Down

0 comments on commit e7b2dc8

Please sign in to comment.