Skip to content

Commit

Permalink
Merge pull request #2517 from minrk/repo2docker-binderhub-update
Browse files Browse the repository at this point in the history
Update repo2docker (Python 3.10 by default) and BinderHub (switch to jupyter-server)
  • Loading branch information
minrk authored Mar 9, 2023
2 parents 8c4b4fb + 4583979 commit 00c05f4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 24 deletions.
2 changes: 1 addition & 1 deletion mybinder/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ dependencies:
# Source code: https://github.com/jupyterhub/binderhub/tree/main/helm-chart
# App changelog: https://github.com/jupyterhub/binderhub/blob/main/CHANGES.md
- name: binderhub
version: "1.0.0-0.dev.git.3018.he00ec49"
version: "1.0.0-0.dev.git.3025.h276be90"
repository: https://jupyterhub.github.io/helm-chart

# Ingress-Nginx to route network traffic according to Ingress resources using
Expand Down
23 changes: 1 addition & 22 deletions mybinder/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ binderhub:

BinderHub:
use_registry: true
build_image: quay.io/jupyterhub/repo2docker:2022.10.0-113.g8c0f49e
build_image: quay.io/jupyterhub/repo2docker:2022.10.0-128.g4c6b5bc
per_repo_quota: 100
per_repo_quota_higher: 200
cors_allow_origin: "*"
Expand Down Expand Up @@ -347,27 +347,6 @@ binderhub:
enabled: true
# replicas set in config/<deployment>
singleuser:
cmd:
- python3
- "-c"
- |
import os
import sys
try:
import jupyterlab
major = int(jupyterlab.__version__.split(".", 1)[0])
except Exception:
have_lab = False
else:
have_lab = major >= 3
if have_lab:
# if recent-enough lab is available, make it the default UI
sys.argv.insert(1, "--NotebookApp.default_url=/lab/")
# launch the notebook server
os.execvp("jupyter-notebook", sys.argv)
# clear singleuser.defaultUrl config from chart
defaultUrl:
cloudMetadata:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_launch.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def test_launch_binder(binder_url):
"""
# Known good version of this repo
repo = "binder-examples/requirements"
ref = "fa84f12"
ref = "50533eb"
build_url = binder_url + f"/build/gh/{repo}/{ref}"
r = requests.get(build_url, stream=True)
r.raise_for_status()
Expand Down

0 comments on commit 00c05f4

Please sign in to comment.