Fix build with hatchling backend #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this require a modern version of hatchling as used in the build environment, declared in the top of pyproject.toml? I think maybe we should declare a lower bound on hatching to a recent version so we know it wont cause issues in older versions. |
consideRatio
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
LGTM, can you also mention hatch or similar in the PR title to help better what this was about in the changelog?
Thank you @martinclaus for your care for this repo!!!
According to the hatch docs, the syntax should work as early as version 1.0. I haven't tested it though ;) |
martinclaus
deleted the
184-build-fails-with-error-metadata-generation-failed
branch
This was referenced Jan 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the build process got broken. It seems to be required now to explicitly include the source directory since it is named differently than the package name which make the include heuristics of hatch to fail.