Add tls_kwargs config to configure underlying ldap3 package tls
#273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/tls-config
branch
from
2ed37ef to
fba5556
Compare
minrk
reviewed
Sep 20, 2024
| @@ -94,6 +95,29 @@ def _observe_use_ssl(self, change): | |||
| """, | |||
| ) | |||
|
|
|||
| tls_kvargs = Dict( | |||
There was a problem hiding this comment.
keyword arguments are ~always called kwargs. Or are these something different?
Suggested change
| tls_kvargs = Dict( | |
| tls_kwargs = Dict( |
There was a problem hiding this comment.
Aaaaaaaaaah thanks for catching this!! I felt something was off but I didn't figure out what.
minrk
reviewed
Sep 20, 2024
| await authenticator.get_authenticated_user( | ||
| None, {"username": "leela", "password": "leela"} | ||
| ) | ||
| except LDAPSSLConfigurationError: |
There was a problem hiding this comment.
usually use with pytest.raises(LDAPSSLConfigurationError): for this pattern
consideRatio
force-pushed
the
pr/tls-config
branch
from
fba5556 to
eeb134d
Compare
|
@minrk I rebased, fixed a commit message, and changed |
|
Thank you for reviewing @minrk!!!!! |
minrk
changed the title
tls_kvargs config to configure underlying ldap3 package tlstls_kwargs config to configure underlying ldap3 package tls
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And together with #258, I think its fair to say this also...
I didn't want to add several separate config options of what can be configured in the
ldap3package through LDAPAuthenticator, so I instead addedtls_kvargsand referenced ldap3 docs and source code for details. Like this we avoid maintenance and a layer that de-couples users fromldap3which really does the work related to TLS anyhow.