Merge pull request #254 from consideRatio/pr/next

tests: avoid reuse of authenticator fixture between tests and add docstring
jupyterhub · Sep 15, 2024 · d4a2e61 · d4a2e61
2 parents cf6d3ae + 0d9950d
commit d4a2e61
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/ldapauthenticator/tests/conftest.py b/ldapauthenticator/tests/conftest.py
@@ -5,7 +5,7 @@
 from ..ldapauthenticator import LDAPAuthenticator
 
 
-@pytest.fixture(scope="session")
+@pytest.fixture()
 def authenticator():
     authenticator = LDAPAuthenticator()
     authenticator.server_address = os.environ.get("LDAP_HOST", "localhost")

diff --git a/ldapauthenticator/tests/test_ldapauthenticator.py b/ldapauthenticator/tests/test_ldapauthenticator.py
@@ -1,4 +1,9 @@
-# Inspired by https://github.com/jupyterhub/jupyterhub/blob/main/jupyterhub/tests/test_auth.py
+"""
+Inspired by https://github.com/jupyterhub/jupyterhub/blob/main/jupyterhub/tests/test_auth.py
+
+Testing data is hardcoded in docker-test-openldap, described at
+https://github.com/rroemhild/docker-test-openldap?tab=readme-ov-file#ldap-structure
+"""
 
 
 async def test_ldap_auth_allowed(authenticator):
@@ -70,7 +75,6 @@ async def test_ldap_auth_use_lookup_dn(authenticator):
         None, {"username": "fry", "password": "fry"}
     )
     assert authorized["name"] == "philip j. fry"
-    authenticator.use_lookup_dn_username = False
 
 
 async def test_ldap_auth_search_filter(authenticator):