search_filter is allow config

allowed_groups still narrows the match
jupyterhub · Sep 17, 2024 · a5cfed7 · a5cfed7
1 parent 321f072
commit a5cfed7
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/ldapauthenticator/ldapauthenticator.py b/ldapauthenticator/ldapauthenticator.py
@@ -547,6 +547,11 @@ async def check_allowed(self, username, auth_model):
             allowed = await allowed
         if allowed is True:
             return True
+        if self.search_filter and not self.allowed_groups:
+            # search_filter was specified
+            # consider matching this filter sufficient to allow access
+            # _IF_ allowed_groups is unspecified
+            return True
         if self.allowed_groups:
             # check allowed groups
             in_groups = set((auth_model.get("auth_state") or {}).get("ldap_groups", []))