Fix implicit string concatenation breaking singleuser_lifecycle_hooks deprecation - #933
Open
Dev9269 wants to merge 2 commits into
Open
Fix implicit string concatenation breaking singleuser_lifecycle_hooks deprecation#933Dev9269 wants to merge 2 commits into
Dev9269 wants to merge 2 commits into
Conversation
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
_deprecated_traits_09, two adjacent string literals were implicitly concatenated:This produced a single bogus entry
"singleuser_allow_privilege_escalationsingleuser_lifecycle_hooks", sosingleuser_lifecycle_hooksnever entered_deprecated_traits. Consequences:_handle_deprecated_configsilently ignoredc.KubeSpawner.singleuser_lifecycle_hooks(no warning, value dropped)_get_deprecated/_set_deprecated) were never created for itAdmins using the documented pre-0.9 name got lifecycle hooks silently never applied to pods.
Fix
Split the strings into separate list entries.
Tests
Added
test_deprecated_singleuser_lifecycle_hooksverifyingc.KubeSpawner.singleuser_lifecycle_hooks = {...}maps through tospawner.lifecycle_hooks. Fails on the old code (config value dropped, stays{}), passes with the fix.Full unit run: 147 passed, 18 skipped (kube-cluster tests).