-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation about how it works in README.md #28
Add documentation about how it works in README.md #28
Conversation
711a6cc
to
caf8dca
Compare
de82d8e
to
236e20f
Compare
@cdibble commented the following on a commit i force-pushed away, making it disappear. Here it is again.
I updated this PR and I think it now answers these kinds of questions @cdibble! Could you contribute with a review of this text perhaps? |
Thanks a lot for your insights about this during our session yesterday @minrk! I've made another pass now, what do you think? |
c793bdc
to
1f31a56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I've left some comments about detail, but I've a suggestion for different structure.
- What factors are taken into consideration for a notebook to be 'culled'. This would talk about CHP activity and when it is triggered, and same for the reports from the user server. This would be a high level description, and helps answer the question of 'What causes a notebook to be culled or not culled?'
- How these factors are calculated technically. This would point to code and add more details as you have done.
I hope this restructuring makes sense?
Thanks @yuvipanda for your feedback!
It does, but I'm not eager to put in the work to get it done, feeling low on energy to iterate even further on this beyond tweaks =/ My work on this started out by trying to help a PR land in z2jh documenting the idle culler there, but as I felt most content should be upstreamed here, I started making this to assist that PR from landing in a sustainable way within z2jh. Would you consider accepting this PR as it is without such restructuring and open an issue about the structure improvement? I pushed a commit to cover your other comments. |
That is absolutely understandable. Thank you for being so open about it! I think I'll accept this PR as is. Do you feel comfortable opening an issue? |
Thanks @yuvipanda! I opened #29 |
Thanks for making the ecosystem better documented, @consideRatio! |
Thanks for all of these efforts @yuvipanda and @consideRatio - sorry for starting us into the morass. But the docs are that much better now and that's great! Thanks again. |
@cdibble started documenting details on how jupyterhub-idle-culler works in jupyterhub/zero-to-jupyterhub-k8s#2267, but I think such documentation should go here and be linked to from a distribution of jupyterhub like z2jh or tljh.
This PR is meant to help users understand
jupyterhub-idle-culler
a bit better so that they can better figure out how to configure it and better understand what to expect it can accomplish and how a kernel culler can work together with it.A rendered preview of the README can be found here. I consider this ready for final review and merge at this point.