enable multiple launchers (with paths) #267
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the configuration in a backwards-compatible way to enable multiple launchers from the same server process.
The public REST API would change (from
launcher_entry
tolauncher_entries
), as does the URL scheme for the icons<server.name>/<launcher.name>
.I opted not to do the submenus, but could.
Additionally, in lab, this makes launcher and layoutrestorer optional, and adds mainmenu and commandpalette, which should make this compatible with jupyterlab-classic (though it wouldn't be exposed in the son-of-tree page, and is probably out of scope for this PR).
I didn't see where launcher_entry is under test, but am happy to add something if requested.