Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for unix_socket #151
Adds support for unix_socket #151
Changes from 3 commits
026dd60
52c5cac
e40ef8d
3950eaa
6383515
4567a6a
09491d7
f16923d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the above, could this please be
JUPYTER_RSESSION_PROXY_USE_SOCKET
instead?Also, since you check for
unix_socket != ""
above, I think this can be reduced toif os.getenv("JUPYTER_RSESSION_PROXY_USE_SOCKET")
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that there is already
RSERVER_TIMEOUT
andRSESSION_TIMEOUT
. So I did not want to introduce a new naming schema and named the variables alsoRSERVER_*
.Wouldn't it be better to change all variable names at once in a separate PR?