Add changelog for version 3.0 #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I choose to make it 3.0 because not needing websockify is a big enough change that will break some dependent projects that relied on using it to detect if the X server was up or not (like https://github.com/sunu/jupyter-remote-qgis-proxy/blob/baf0d373c2f965a60bc6fe038bb04cacc8df8cf5/jupyter_remote_qgis_proxy/utils.py#L44)
|
I will automatically update this comment whenever this PR is modified |
manics
reviewed
Jul 19, 2024
| Major change is that [websockify](https://github.com/novnc/websockify) | ||
| is no longer required! | ||
|
|
||
| ([full changelog](https://github.com/jupyterhub/jupyter-remote-desktop-proxy/compare/v2.0.1...30e67ebda5f4e442636e1532b39602850bcff418)) |
There was a problem hiding this comment.
Suggested change
| ([full changelog](https://github.com/jupyterhub/jupyter-remote-desktop-proxy/compare/v2.0.1...30e67ebda5f4e442636e1532b39602850bcff418)) | |
| ([full changelog](https://github.com/jupyterhub/jupyter-remote-desktop-proxy/compare/v2.0.1...v3.0.0)) |
|
|
||
| ### Bugs fixed | ||
|
|
||
| - Pin @novnc/novnc 1.4.x pending 1.5.x compatibility [#120](https://github.com/jupyterhub/jupyter-remote-desktop-proxy/pull/120) ([@manics](https://github.com/manics), [@consideRatio](https://github.com/consideRatio)) |
There was a problem hiding this comment.
I think it'll be clearer if this is moved to other PRs alongside the 1.5.0 fix, or move the 1.5.0 PR to this section, since they're obviously related.
|
Other than those comments go ahead with a release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I choose to make it 3.0 because not needing websockify is a big enough change that will break some dependent projects that relied on using it to detect if the X server was up or not (like https://github.com/sunu/jupyter-remote-qgis-proxy/blob/baf0d373c2f965a60bc6fe038bb04cacc8df8cf5/jupyter_remote_qgis_proxy/utils.py#L44)