Cleanup logic to populate variables no longer needed #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had logic to pre-populate variables values, but I've conluded it doesn't seem to be needed any more. Whenever I deploy entirely fresh dashboards and visit them, the variables are up to date. I think they are both refreshed on load and on time range change now.
Related config
query.refresh.onLoad
andquery.refresh.onTime
could be declared explicitly four our variables declared here, but the default seems to be to have those refresh, which is fine and makes us not need the code removed in this PR.Related issues
get_label_values
#98 as its removing code triggering error