Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup logic to populate variables no longer needed #125

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Apr 13, 2024

We had logic to pre-populate variables values, but I've conluded it doesn't seem to be needed any more. Whenever I deploy entirely fresh dashboards and visit them, the variables are up to date. I think they are both refreshed on load and on time range change now.

refresh-variables

Related config

query.refresh.onLoad and query.refresh.onTime could be declared explicitly four our variables declared here, but the default seems to be to have those refresh, which is fine and makes us not need the code removed in this PR.

Related issues

@consideRatio consideRatio added the bug Something isn't working label Apr 17, 2024
@consideRatio
Copy link
Member Author

consideRatio commented Apr 17, 2024

I've rechecked all dashboards - this work the same with and without this functionality.

I also think now that this would close #32 and #98, which have errors related to the removed code.

@consideRatio consideRatio added maintenance bug Something isn't working and removed bug Something isn't working maintenance labels Apr 17, 2024
@consideRatio consideRatio merged commit 832e761 into jupyterhub:main Apr 18, 2024
2 of 3 checks passed
@consideRatio
Copy link
Member Author

I did a third self-review and went for a self-merge!

I worry that the bugs in this code this could cause someone looking to trial these dashboards to fail. I just suggested in https://discourse.jupyter.org/t/grafana-dashboard/25249/3 that a user could try deploy at least one of the dashboards in a non-k8s context - and I guess without knowing that this code could be erroring for a grafana deployed outside k8s context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 when trying to access proxy_url in get_label_values Cannot install JupyterHub dashboards
1 participant