Merge pull request #59 from yuvipanda/latency

Exclude SpawnProgressAPIHandler from latency metrics
jupyterhub · Feb 13, 2023 · 04e2d15 · 04e2d15
2 parents 099037b + 1a9c24b
commit 04e2d15
Showing 1 changed file with 30 additions and 2 deletions.
diff --git a/dashboards/jupyterhub.jsonnet b/dashboards/jupyterhub.jsonnet
@@ -202,11 +202,39 @@ local hubResponseLatency = graphPanel.new(
   datasource='$PROMETHEUS_DS'
 ).addTargets([
   prometheus.target(
-    'histogram_quantile(0.99, sum(rate(jupyterhub_request_duration_seconds_bucket{app="jupyterhub", namespace=~"$hub"}[5m])) by (le))',
+    |||
+      histogram_quantile(
+        0.99,
+        sum(
+          rate(
+            jupyterhub_request_duration_seconds_bucket{
+              app="jupyterhub",
+              namespace=~"$hub",
+              # Ignore SpawnProgressAPIHandler, as it is a EventSource stream
+              # and keeps long lived connections open
+              handler!="jupyterhub.apihandlers.users.SpawnProgressAPIHandler"
+            }[5m]
+          )
+        ) by (le))
+    |||,
     legendFormat='99th percentile'
   ),
   prometheus.target(
-    'histogram_quantile(0.50, sum(rate(jupyterhub_request_duration_seconds_bucket{app="jupyterhub", namespace=~"$hub"}[5m])) by (le))',
+    |||
+      histogram_quantile(
+        0.50,
+        sum(
+          rate(
+            jupyterhub_request_duration_seconds_bucket{
+              app="jupyterhub",
+              namespace=~"$hub",
+              # Ignore SpawnProgressAPIHandler, as it is a EventSource stream
+              # and keeps long lived connections open
+              handler!="jupyterhub.apihandlers.users.SpawnProgressAPIHandler"
+            }[5m]
+          )
+        ) by (le))
+    |||,
     legendFormat='50th percentile'
   ),
 ]);