Move from DockerHub to quay.io #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Companion PR to jupyterhub/zero-to-jupyterhub-k8s#3254. See that PR for more information.
Open
9 tasks
minrk
reviewed
Oct 20, 2023
| @@ -68,7 +68,7 @@ jobs: | |||
| # https://github.com/jupyterhub/configurable-http-proxy/settings/secrets/actions | |||
| if: startsWith(github.ref, 'refs/tags/') | |||
| run: | | |||
| docker login -u "${{ secrets.DOCKERHUB_USERNAME }}" -p "${{ secrets.DOCKERHUB_TOKEN }}" | |||
| docker login -u "${{ secrets.QUAY_USERNAME }}" -p "${{ secrets.QUAY_PASSWORD }}" quay.io | |||
There was a problem hiding this comment.
This changes the creds, but doesn't change where it's pushed (next step in gettags needs quay.io added, I think)
There was a problem hiding this comment.
@minrk how about now?
minrk
approved these changes
Oct 20, 2023
|
Thanks @minrk. I'll use workflow dispatch to run this just in case. |
|
I just re-pushed 4.6.0 but realized that won't actually trigger the new workflow, only the old one. I don't want to make a fresh release, so I've just re-run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to
jupyterhub/zero-to-jupyterhub-k8s#3254. See that PR for more information.