-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs: index merge, image tag, g prefix, ignored tags #64
Merged
minrk
merged 8 commits into
jupyterhub:master
from
consideRatio:fix-helm-index-merges-bug
Oct 22, 2019
Merged
Fix bugs: index merge, image tag, g prefix, ignored tags #64
minrk
merged 8 commits into
jupyterhub:master
from
consideRatio:fix-helm-index-merges-bug
Oct 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
Fix bugs: index merge, image tag, g prefix
[WIP] Fix bugs: index merge, image tag, g prefix
Oct 21, 2019
consideRatio
commented
Oct 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes to self
- refactor the now chart/image common logic into a function.
- create a function to identify build section and strip it, and stop sending two return values in a tuple as i started doing in this PR
consideRatio
force-pushed
the
fix-helm-index-merges-bug
branch
from
October 21, 2019 11:59
1846269
to
6937d2f
Compare
consideRatio
force-pushed
the
fix-helm-index-merges-bug
branch
from
October 21, 2019 12:06
6937d2f
to
af36ad7
Compare
We failed to update the chart version or image tag if there was a git tag more recent that the latest modifying commit. This commit fixes that.
consideRatio
changed the title
[WIP] Fix bugs: index merge, image tag, g prefix
Fix bugs: index merge, image tag, g prefix
Oct 21, 2019
consideRatio
changed the title
Fix bugs: index merge, image tag, g prefix
Fix bugs: index merge, image tag, g prefix, ignored tags
Oct 21, 2019
Excellent! |
Not sure if it was this PR or not, but I'm getting the same effective last-changed commit on all images, regardless of when the image's files were last changed. |
f41990c - this is probably the relevant change commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key issue fixed: index merge
Closes #62 that followed an issue introduced by #52 by implementing #62 (comment) and catching some past mistakes of mine along the way. Fixing #62 is urgent as chartpress 0.4.2 is breaking expected functionality of chartpress.
Additional issues fixed
-
instead of.
as separator for image tags, which was not according to plan or inline documentation.Other
last_modified_date(*paths)
._get_identifier
and_strip_identifiers_build_suffix