Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump base image versions used #1930

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

yuvipanda
Copy link
Collaborator

There's a segfault in the helm chart publish workflow that isn't being resolved by simply rebuilding (https://github.com/jupyterhub/binderhub/actions/runs/13316495693/job/37191967146).

So this bumps up the base versions of everything to something more modern, and hopefully when merged will cause a helm chart to actually publish.

There's a segfault in the helm chart publish workflow that
isn't being resolved by simply rebuilding (https://github.com/jupyterhub/binderhub/actions/runs/13316495693/job/37191967146).

So this bumps up the base versions of everything to something more
modern, and hopefully when merged will cause a helm chart to actually
publish.
@yuvipanda yuvipanda requested review from minrk and manics February 13, 2025 20:44
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable changes, but the bump to py 3.13 from 3.11 in the binder pod is worth highlighting in the title and a "breaking" label (as it could impact extraConfig or added dependencies not compatible with py 3.13)

@consideRatio
Copy link
Member

If you just want to refreeze in this/z2jh/binderhub-service repos you can also trigger the workflow https://github.com/jupyterhub/binderhub/actions/workflows/watch-dependencies.yaml btw!

@yuvipanda yuvipanda merged commit 1da3d9a into jupyterhub:main Feb 13, 2025
15 checks passed
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Feb 13, 2025
yuvipanda added a commit to yuvipanda/mybinder.org-deploy that referenced this pull request Feb 14, 2025
Brings in:

repo2docker (among others):
- jupyterhub/repo2docker#1402
- jupyterhub/repo2docker#1413

binderhub:
- jupyterhub/binderhub#1929
- jupyterhub/binderhub#1930

Note that this *could* cause some issues for the very few repos
that depend on internal details of the non buildx old builder.
For example, see scikit-learn/scikit-learn#30835
yuvipanda added a commit to yuvipanda/mybinder.org-deploy that referenced this pull request Feb 14, 2025
Brings in:

repo2docker (among others):
- jupyterhub/repo2docker#1402
- jupyterhub/repo2docker#1413

binderhub:
- jupyterhub/binderhub#1929
- jupyterhub/binderhub#1930

Note that this *could* cause some issues for the very few repos
that depend on internal details of the non buildx old builder.
For example, see scikit-learn/scikit-learn#30835

We also remove memory limits, as those are not supported right now
via the docker buildx build. We will need to add support for custom
buildkit builders in binderhub, and then we can use those.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants