Only mount ~/.docker/config.json, not ~/.docker #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker buildx wants to write to ~/.docker/buildx, but since we mount the secret *entirely* (to ~/.docker/buildx), it can not. I think mounting *just* the subpath should work. Follow-up to jupyterhub/repo2docker#1402
minrk
approved these changes
Feb 13, 2025
|
There is a slight behavior change that i don't think is a problem, but I'm not 100% confident on it - it could even be that this is a fix to an edge case. With subPath is used, it wont refresh the mounted config file over time if the source Secret/ConfigMap changes, but that seems fine as long as the pod isn't staying around for multiple builds etc - which it won't, right? |
yuvipanda
added a commit
to yuvipanda/mybinder.org-deploy
that referenced
this pull request
Feb 14, 2025
Brings in: repo2docker (among others): - jupyterhub/repo2docker#1402 - jupyterhub/repo2docker#1413 binderhub: - jupyterhub/binderhub#1929 - jupyterhub/binderhub#1930 Note that this *could* cause some issues for the very few repos that depend on internal details of the non buildx old builder. For example, see scikit-learn/scikit-learn#30835
yuvipanda
added a commit
to yuvipanda/mybinder.org-deploy
that referenced
this pull request
Feb 14, 2025
Brings in: repo2docker (among others): - jupyterhub/repo2docker#1402 - jupyterhub/repo2docker#1413 binderhub: - jupyterhub/binderhub#1929 - jupyterhub/binderhub#1930 Note that this *could* cause some issues for the very few repos that depend on internal details of the non buildx old builder. For example, see scikit-learn/scikit-learn#30835 We also remove memory limits, as those are not supported right now via the docker buildx build. We will need to add support for custom buildkit builders in binderhub, and then we can use those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker buildx wants to write to ~/.docker/buildx, but since we mount the secret entirely (to ~/.docker/buildx), it can not. I think mounting just the subpath should work.
Follow-up to jupyterhub/repo2docker#1402