Allow Access-Control-Allow-Origin=* on /versions API
#1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
minrk
approved these changes
Jan 13, 2025
|
Thanks for the approval @minrk :) I assume that the failed test job is unrelated to this PR. |
|
The original test run failed due to an external problem, I've rerun them and this looks like a genuine error, all tests are passing on the main branch. |
minrk
reviewed
Jan 15, 2025
Co-authored-by: Min RK <[email protected]>
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Jan 15, 2025
jupyterhub/binderhub#1906 Merge pull request #1906 from agoose77/agoose77/fix-cors-versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the BinderHub counterpart to jupyterhub/jupyterhub#4966. It is intended to expose the unauthenticated
/versionsAPI call to cross-origin queries, enabling use in contexts where CORS would otherwise prohibit the fetch.By merging this PR, all BinderHub deployments will now be able to answer a question of the form "are you a BinderHub", which is useful for us over in the Jupyter Book ecosystem (see the above PR!)
I took the same approach here as JupyterHub, so I hope it's not a contentious PR!