Change component name from dind to image-builder #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In parallel of the work from jupyterhub#1531, this change will allow the use of other builders than Docker without being tied to its nomenclature which might make the whole a bit confusing when deploying and debugging.
manics
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
This change makes sense to me.
@minrk @consideRatio Are you aware of anything that relies on component: dind?
|
I'm not sure, about tooling relying on identifying the pods by the I looked but found nothing. Seems reasonable to me! I wonder if upgrading to this binderhub version will make the active build pods be abandoned or similar? If so its good that such notes are part of the PR description so that upgrades can be made during low load at least. |
|
Yeah, if anything I would guess it's only something in grafana or possibly a network policy. |
|
Thanks all, merging! |
manics
added a commit
to manics/mybinder.org-deploy
that referenced
this pull request
Oct 30, 2022
`component=dind` is changing to `component=image-builder` jupyterhub/binderhub#1543
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Oct 30, 2022
jupyterhub/binderhub#1543 Merge pull request #1543 from sgaist/refactor_dind_label
manics
added a commit
to manics/binderhub
that referenced
this pull request
Dec 16, 2022
manics
added a commit
to manics/binderhub
that referenced
this pull request
Dec 16, 2022
manics
added a commit
to manics/binderhub
that referenced
this pull request
Dec 16, 2022
manics
added a commit
to manics/binderhub
that referenced
this pull request
Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In parallel of the work from #1531, this change will allow the use of other builders than Docker without being tied to its nomenclature which might make the whole a bit confusing when deploying and debugging.
Part of #1513