Skip to content

Commit

Permalink
disable schema validation when installing for a different version
Browse files Browse the repository at this point in the history
config is for the new version, don't validate it against the old schema,
otherwise PRs updating the schema will always fail CI
  • Loading branch information
minrk committed Apr 25, 2022
1 parent f0db8e4 commit b251afa
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/diff.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,13 @@ jobs:
# NOTE: We change the directory so binderhub the chart name won't be
# misunderstood as the local folder name.
# validation is disabled, because the config is for a different version!
cd testing
helm install binderhub-test binderhub \
--values ./k8s-binder-k8s-hub/binderhub-chart-config.yaml \
--repo https://jupyterhub.github.io/helm-chart/ \
--disable-openapi-validation \
--version=$UPGRADE_FROM_VERSION
- name: "Helm diff latest released dev chart with local chart"
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ jobs:
cd ci
helm install binderhub-test \
--repo https://jupyterhub.github.io/helm-chart/ binderhub \
--disable-openapi-validation \
--version=$UPGRADE_FROM_VERSION \
--values ../testing/k8s-binder-k8s-hub/binderhub-chart-config.yaml \
--set config.BinderHub.hub_url=http://localhost:30902 \
Expand Down

0 comments on commit b251afa

Please sign in to comment.