Skip to content

Commit

Permalink
For some reason need to await io_loop fixture
Browse files Browse the repository at this point in the history
  • Loading branch information
manics committed Aug 1, 2022
1 parent b04f526 commit 5bf4982
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions binderhub/tests/test_build.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,9 @@ def test_git_credentials_passed_to_podspec_upon_submit():


async def test_local_repo2docker_build(io_loop):
# Todo: why is await necessary? Without await:
# AttributeError: 'coroutine' object has no attribute 'run_in_executor'
io_loop = await io_loop
q = Queue()
repo_url = "https://github.com/binderhub-ci-repos/cached-minimal-dockerfile"
ref = "HEAD"
Expand Down Expand Up @@ -248,6 +251,7 @@ async def test_local_repo2docker_build(io_loop):

@pytest.mark.asyncio(timeout=20)
async def test_local_repo2docker_build_stop(io_loop):
io_loop = await io_loop
q = Queue()
# We need a slow build here so that we can interrupt it, so pick a large repo that
# will take several seconds to clone
Expand Down

0 comments on commit 5bf4982

Please sign in to comment.