Wrapspawner/JH0.9.4 compatibilty: get_current_user and current_port #132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two problems:
First is a compatibility for JupyterHub later than 0.9.4 (but not inclusive). get_current_user became async, and thus we need to handle both old and new hubs. This adds some logic to use the non-async version to avoid making this whole method async - because
jupyterhub.util.maybe_future
is also relatively new so would need backwards compatibility to use itself. Closes: #131Second, wrapspawner has to proxy the
self.current_port
setting toself.child_spawner.current_port
. It would be better to solve this in wrapspawner, since many different things could be set. But this might solve the problem faster. Closes: #129, #127,These are together because they touch lines almost identical to each other. They can easily be split.