Skip to content

Commit

Permalink
Fix tests by excluding broken version combo
Browse files Browse the repository at this point in the history
Jupyterhub 0.9.6 used a deprecated import (sqlalchemy.interfaces) that was removed in Sqlalchemy 1.4. The python 3.5 environment only installs 1.3, but the python 3.9 environment now uses 1.4 and thus Jupyterhub fails to run. Excluding this test instead of adding a version pin since running such an old JHub in a very modern environment should be quite rare.
  • Loading branch information
mbmilligan authored Mar 5, 2022
1 parent 1decdf2 commit 33ddb8b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ jobs:
# JupyterHub 1.3.0 requires python 3.6+
- JHUB_VER: "1.3.0"
python-version: "3.5"
# JupyterHub 0.9.6 used a deprecated sqlalchemy feature removed in py3.9 environment
- JHUB_VER: "0.9.6"
python-version: "3.9"
include:
- JHUB_VER: "master"
python-version: "3.9"
Expand Down

0 comments on commit 33ddb8b

Please sign in to comment.