Merge pull request #38 from manics/noref

Handle empty ref
jupyterhub · Feb 10, 2021 · 1a08fa6 · 1a08fa6
2 parents 98300ea + 449c623
commit 1a08fa6
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 6 deletions.
diff --git a/__tests__/main.test.js b/__tests__/main.test.js
@@ -136,7 +136,7 @@ test("Unsupported prerelease tag", async () => {
 test("Not a tag", async () => {
   await expect(
     calculateTags("TOKEN", "owner", "repo", "something/else", "")
-  ).rejects.toEqual(new Error("Not a tag: something/else"));
+  ).rejects.toEqual(new Error("Not a tag or branch: something/else"));
 });
 
 test("Invalid semver tag", async () => {
@@ -145,6 +145,11 @@ test("Invalid semver tag", async () => {
   ).rejects.toEqual(new Error("Invalid semver tag: v1"));
 });
 
+test("No ref", async () => {
+  const tags = await calculateTags("TOKEN", "owner", "repo", null, "");
+  expect(tags).toEqual([]);
+});
+
 test("Prefix", async () => {
   const scope = nock("https://api.github.com")
     .get("/repos/owner/repo/tags")

diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/index.js b/src/index.js
@@ -14,13 +14,17 @@ function supportedPrerelease(pre) {
 async function calculateTags(token, owner, repo, ref, prefix) {
   core.debug(`ref: ${ref}`);
 
+  if (!ref) {
+    core.debug("No ref");
+    return [];
+  }
   if (ref.startsWith("refs/heads/")) {
     const branch = ref.substring(11);
-    core.debug(`Branch: branch`);
+    core.debug(`Branch: ${branch}`);
     return [`${prefix}${branch}`];
   }
   if (!ref.startsWith("refs/tags/")) {
-    throw new Error(`Not a tag: ${ref}`);
+    throw new Error(`Not a tag or branch: ${ref}`);
   }
 
   const currentTag = ref.substring(10);