Skip to content

hotfix to unbreak syntax highlighting #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohanMabille merged 5 commits into from
Feb 23, 2026
Merged

hotfix to unbreak syntax highlighting #692

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
be318e6
hotfix to unbreak syntax highlighting
DerThorsten Feb 23, 2026
6554f2d
codemirror as dict
DerThorsten Feb 23, 2026
bc23a45
codemirror as dict, 5.5
DerThorsten Feb 23, 2026
76a89fd
use helpers
DerThorsten Feb 23, 2026
5a30262
overwrite
DerThorsten Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions src/xinterpreter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,28 +301,29 @@ namespace xpyt
});

bool has_debugger = (PY_MAJOR_VERSION != 3) || (PY_MAJOR_VERSION != 13);
nl::json rep = xeus::create_info_reply(
"5.5", // protocol_version - overwrited in xeus core
"xeus-python", // implementation
XPYT_VERSION, // implementation_version
"python", // language_name
PY_VERSION, // language_version
"text/x-python", // language_mimetype
".py", // language_file_extension
"ipython" + std::to_string(PY_MAJOR_VERSION), // pygments_lexer
R"({"name": "ipython", "version": )" + std::to_string(PY_MAJOR_VERSION) + "}", // language_codemirror_mode
"python", // language_nbconvert_exporter
banner, // banner
has_debugger, // debugger
help_links // help_links
);

nl::json kernel_res;
kernel_res["status"] = "ok";
kernel_res["protocol_version"] = "5.3";
Copy link
Member

@JohanMabille JohanMabille Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 5.5.

kernel_res["implementation"] = "xeus-python";
kernel_res["implementation_version"] = XPYT_VERSION;
kernel_res["language_info"]["name"] = "python";
kernel_res["language_info"]["version"] = PY_VERSION;
kernel_res["language_info"]["mimetype"] = "text/x-python";
kernel_res["language_info"]["file_extension"] = ".py";
kernel_res["language_info"]["pygments_lexer"] = "ipython" + std::to_string(PY_MAJOR_VERSION);
// this breaks syntax highlighting
//kernel_res["language_info"]["codemirror_mode"] = R"({"name": "ipython", "version": )" + std::to_string(PY_MAJOR_VERSION) + "}";
kernel_res["language_info"]["nbconvert_exporter"] = "python";
kernel_res["banner"] = banner;
kernel_res["debugger"] = has_debugger;
kernel_res["help_links"] = help_links;

if (has_debugger)
{
rep["supported_features"] = nl::json::array({"debugger"});
kernel_res["supported_features"] = nl::json::array({"debugger"});
}

return rep;
return kernel_res;
}

void interpreter::shutdown_request_impl()
Expand Down