Implement debugger options just_my_code and internal frame filtering#677
Draft
arjxn-py wants to merge 2 commits intojupyter-xeus:mainfrom
Draft
Implement debugger options just_my_code and internal frame filtering#677arjxn-py wants to merge 2 commits intojupyter-xeus:mainfrom
just_my_code and internal frame filtering#677arjxn-py wants to merge 2 commits intojupyter-xeus:mainfrom
Conversation
arjxn-py
changed the title
just-my-code and internal frame filt…just-my-code and internal frame filtering
arjxn-py
changed the title
just-my-code and internal frame filteringjust-my-code and internal frame filtering
arjxn-py
changed the title
just-my-code and internal frame filteringjust_my_code and internal frame filtering
Member
|
The CI issue will be fixed by #680 |
martinRenou
force-pushed
the
filter-internal-modules
branch
from
16172d2 to
3d63612
Compare
martinRenou
requested changes
Dec 8, 2025
src/xdebugger.cpp
Outdated
Comment on lines
73
to
79
| if (m_debugger_config.contains("internalModulePaths")) | ||
| { | ||
| for (const auto& p : m_debugger_config["internalModulePaths"]) | ||
| { | ||
| m_internal_modules.push_back(p.get<std::string>()); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
What is this?
I don't see an equivalent of this in the ipykernel PR
src/xdebugger.cpp
Outdated
Comment on lines
81
to
90
| // Load options | ||
| if (m_debugger_config.contains("justMyCode")) | ||
| { | ||
| m_just_my_code = m_debugger_config["justMyCode"].get<bool>(); | ||
| } | ||
|
|
||
| if (m_debugger_config.contains("filterInternalFrames")) | ||
| { | ||
| m_filter_internal_frames = m_debugger_config["filterInternalFrames"].get<bool>(); | ||
| } |
Member
There was a problem hiding this comment.
It doesn't seem this code path will ever be reached? I understand the debugger_config is only internal and it cannot be set from the outside, so those if condition will never be true?
| std::string path = mod.attr("__file__").cast<std::string>(); | ||
| internal_mod_paths.push_back(path); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
We should also do this for interpreter-raw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#678