Move files_handler_params default from FileContentsManager to ContentsManager#1496
Open
MaicoTimmerman wants to merge 1 commit intojupyter-server:mainfrom
Open
Conversation
51bfc61 to
839f1c9
Compare
… to match files_handler_class default
839f1c9 to
858007d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the default
files_handler_paramsfromFileContentsManagertoContentsManagerto match its signature.In
https://github.com/jupyter-server/jupyter_server/pull/1069/files#diff-4d8c8c45026f674a455c1e41558c6a9a05d8766adc81a6e56d8cafc7e5d8077cR17 the
web.StaticFileHandlerwas introduced as superclass toFilesHandler. This causes all subclasses ofContentsManager(e.g. a version for S3) to fail serving the file due to: