Remove Python 3.8 to fix build issues#1409
Draft
lresende wants to merge 52 commits intojupyter-server:mainfrom
Draft
Remove Python 3.8 to fix build issues#1409lresende wants to merge 52 commits intojupyter-server:mainfrom
lresende wants to merge 52 commits intojupyter-server:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for Python 3.8 to fix build issues by updating version requirements across configuration files and documentation.
- Updated classifiers and the Python requirement in pyproject.toml
- Updated Docker README and environment.yml to reflect Python 3.9
- Updated workflow configurations in .github/workflows/build.yml to remove Python 3.8 support
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Removed Python 3.8 classifier and updated requires-python to >=3.9 |
| etc/docker/demo-base/README.md | Updated description to indicate usage of Python 3.9 |
| docs/environment.yml | Changed the Python dependency version from 3.8 to 3.9 |
| .github/workflows/build.yml | Removed Python 3.8 from the test matrix and updated configuration |
kevin-bates
approved these changes
Jun 23, 2025
Member
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
Thank you @lresende. This has my approval whenever you are done.
Member
Author
|
Thank you @kevin-bates , I believe there are two main issues here:
Will find some time and continue on this until we get a green build |
lresende
force-pushed
the
remove-py-38
branch
2 times, most recently
from
67e736f to
9943114
Compare
lresende
force-pushed
the
remove-py-38
branch
2 times, most recently
from
0dc0b1a to
8b0e0a0
Compare
Update ssh keygen Uses python 3.10
Carreau
force-pushed
the
remove-py-38
branch
from
73f223e to
8bde24e
Compare
Carreau
force-pushed
the
remove-py-38
branch
from
ed76853 to
610f445
Compare
Carreau
force-pushed
the
remove-py-38
branch
from
bc85292 to
37e0b4d
Compare
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DORMANT PR - WAITING FOR TOREE RELEASE TO CHERRY-PICK SPARK RELATED CHANGES