Prometheus http and kernel startup/shutdown metrics#1377
Open
MaicoTimmerman wants to merge 1 commit intojupyter-server:mainfrom
Open
Prometheus http and kernel startup/shutdown metrics#1377MaicoTimmerman wants to merge 1 commit intojupyter-server:mainfrom
MaicoTimmerman wants to merge 1 commit intojupyter-server:mainfrom
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
37470d3 to
a71811f
Compare
ffc7508 to
27d5472
Compare
Author
|
Read the docs build failed due to timeouts: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This MR is taking on #731.
The
jupyter_serveralready ships with aPrometheusMetricsHandler, however, that handler inherits fromJupyterHandler, which requires authentication. The enterprise gateway project doesn't integrate with that method of authentication, therefore I added separate handler to serve the metrics.I've included 3 metrics in the initial implementation:
In terms of configuration, I've included the
EG_METRICS_PREFIXenvironment variable for now, similar to how other configurations for the process proxies are set.Sample responses from the /metrics endpoint
enterprise_gateway_http_request_duration_seconds_bucket{handler="enterprise_gateway.services.kernels.handlers.KernelActionHandler",le="0.005",method="POST",status_code="200"} 0.0 enterprise_gateway_http_request_duration_seconds_bucket{handler="enterprise_gateway.services.kernels.handlers.KernelActionHandler",le="0.01",method="POST",status_code="200"} 0.0 enterprise_gateway_http_request_duration_seconds_bucket{handler="enterprise_gateway.services.kernels.handlers.KernelActionHandler",le="0.025",method="POST",status_code="200"} 0.0 enterprise_gateway_http_request_duration_seconds_bucket{handler="enterprise_gateway.services.kernels.handlers.KernelActionHandler",le="0.05",method="POST",status_code="200"} 0.0 enterprise_gateway_http_request_duration_seconds_bucket{handler="enterprise_gateway.services.kernels.handlers.KernelActionHandler",le="0.075",method="POST",status_code="200"} 0.0 enterprise_gateway_http_request_duration_seconds_bucket{handler="enterprise_gateway.services.kernels.handlers.KernelActionHandler",le="0.1",method="POST",status_code="200"} 0.0 enterprise_gateway_http_request_duration_seconds_bucket{handler="enterprise_gateway.services.kernels.handlers.KernelActionHandler",le="0.25",method="POST",status_code="200"} 0.0 enterprise_gateway_http_request_duration_seconds_bucket{handler="enterprise_gateway.services.kernels.handlers.KernelActionHandler",le="0.5",method="POST",status_code="200"} 0.0 enterprise_gateway_http_request_duration_seconds_bucket{handler="enterprise_gateway.services.kernels.handlers.KernelActionHandler",le="0.75",method="POST",status_code="200"} 0.0 enterprise_gateway_http_request_duration_seconds_bucket{handler="enterprise_gateway.services.kernels.handlers.KernelActionHandler",le="1.0",method="POST",status_code="200"} 0.0 enterprise_gateway_http_request_duration_seconds_bucket{handler="enterprise_gateway.services.kernels.handlers.KernelActionHandler",le="2.5",method="POST",status_code="200"} 0.0 enterprise_gateway_http_request_duration_seconds_bucket{handler="enterprise_gateway.services.kernels.handlers.KernelActionHandler",le="5.0",method="POST",status_code="200"} 0.0 enterprise_gateway_http_request_duration_seconds_bucket{handler="enterprise_gateway.services.kernels.handlers.KernelActionHandler",le="7.5",method="POST",status_code="200"} 0.0 enterprise_gateway_http_request_duration_seconds_bucket{handler="enterprise_gateway.services.kernels.handlers.KernelActionHandler",le="10.0",method="POST",status_code="200"} 0.0 enterprise_gateway_http_request_duration_seconds_bucket{handler="enterprise_gateway.services.kernels.handlers.KernelActionHandler",le="+Inf",method="POST",status_code="200"} 1.0 enterprise_gateway_http_request_duration_seconds_count{handler="enterprise_gateway.services.kernels.handlers.KernelActionHandler",method="POST",status_code="200"} 1.0 enterprise_gateway_http_request_duration_seconds_sum{handler="enterprise_gateway.services.kernels.handlers.KernelActionHandler",method="POST",status_code="200"} 19.83746862411499