Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump jupyterlab/builder, remove package-lock.json #914

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

bollwyvl
Copy link
Collaborator

@bollwyvl bollwyvl commented Mar 13, 2023

References

Code changes

  • removes package-lock.json
    • npm i wouldn't even run, after thinking about it for five minutes
  • bump @jupyterlab/builder all over
    • removes not-a-package hacks
    • doesn't even mention verdaccio

User-facing changes

  • n/a

Backwards-incompatible changes

  • n/a

Chores

  • linted
    • i ran this, and it did... a lot. reckon out of scope
  • tested
    • waiting for CI
  • documented
    • n/a
  • changelog entry
    • n/a

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch bollwyvl/jupyterlab-lsp/gh-891-alt-bump-builder

@bollwyvl bollwyvl marked this pull request as ready for review March 13, 2023 23:15
@bollwyvl
Copy link
Collaborator Author

Seems a fair amount of stuff passing, so taking off draft.

Re-asking (rather than buried in a comment): why is there even a package-lock.json (corollary: how'd you get it to resolve?)

@krassowski
Copy link
Member

From history it looks like there was no good reason, it was just pulled in #452 and no one noticed/objected.

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@krassowski krassowski merged commit c8a7d6c into jupyter-lsp:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants