Update pylsp.schema.json to match upstream schema #1157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from pylsp/config/schema.json Fixes jupyter-lsp#1156
|
|
|
I don't think linting and documentation are relevant to this change (correct me if I'm wrong). I have not tested the change, as the binder link fails to build, but I'm hoping this sort of change is simple and safe enough without testing. |
|
Linting is relevant here. |
|
Hmm, sure is. I was hoping that trusting upstream would be enough, but it looks like you don't just want a direct copy of the upstream schema file. I'm afraid I don't have time right now to set up the dev environment and/or work out the style/linting standards for this file. I'm sorry if I'm wasting your time with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #1156 (at least the immediate issue raised there).
Code changes
Copied schema from upstream pylsp/config/schema.json
User-facing changes
Should affect configuration options visible in Jupyterlab settings.
Backwards-incompatible changes
Chores