Skip to content

Conversation

krassowski
Copy link
Member

Prepare jupyter-lsp 2.3.0 release

Copy link

Binder 👈 Launch a binder notebook on branch krassowski/jupyterlab-lsp/prepare-2.3

@krassowski
Copy link
Member Author

It looks like tests are failing if Python (basepyright) runs after other Python tests.

@krassowski
Copy link
Member Author

krassowski commented Aug 25, 2025

Note: the PR adding basedpyright, #1152 run with basedpyright v1.31.2 on CI whereas v1.31.3 was released just a few days back (but was not on conda-forge yet at the time, it is now). v1.31.3 is based on more recent pyright which has some performance improvements which may be introducing a regression see:

If this passes now after d0cf443, it means that new pyright/basepyright is likely introducing a severe regression on macos and windows (but curiously not on ubuntu?)/

@krassowski
Copy link
Member Author

It looks like this is "our" problem - the basedpyright installation does not get detected. Maybe we need to check basedpyright_langserver in addition to basedpyright-langserver? But why did it work initially?

@krassowski
Copy link
Member Author

Hmm it is still a problem. But wait, I think I see what is wrong. Is it using the released 2.2.6 instead of 2.3.0 on CI:

image

So is it an issue introduced by a new pip version maybe?

@krassowski
Copy link
Member Author

well splitting it across two lines did not help:

image

@bollwyvl is there something obviously wrong I am doing here?

@krassowski
Copy link
Member Author

Maybe it is a red herring because the same version is printed out on passing ubuntu jobs:

image

@krassowski
Copy link
Member Author

Uninstalling the old version beforehand did it.

@krassowski krassowski merged commit 6d2a0d9 into jupyter-lsp:main Aug 27, 2025
18 of 19 checks passed
@krassowski krassowski deleted the prepare-2.3 branch August 27, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant