Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of conda-incubator/setup-miniconda #1112

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 8, 2025

References

Looking into #1111

Code changes

User-facing changes

Backwards-incompatible changes

Chores

  • linted
  • tested
  • documented
  • changelog entry

Copy link

github-actions bot commented Jan 8, 2025

Binder 👈 Launch a binder notebook on branch jtpio/jupyterlab-lsp/fix-ci

@jtpio jtpio changed the title Drop miniforge-variant Fix usage of conda-incubator/setup-miniconda Jan 8, 2025
@jtpio jtpio marked this pull request as ready for review January 8, 2025 16:52
@@ -333,10 +328,6 @@ jobs:
path: ./build/reports
if: always()

- name: Rename uncached conda packages
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this was needed but it was failing. Also I would expect something like this to be handled by the conda-incubator/setup-miniconda action directly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it was added in #882, more specifically in a4fb737

@jtpio
Copy link
Member Author

jtpio commented Jan 8, 2025

Stopping here since the "Set up Python and mamba" steps using conda-incubator/setup-miniconda@v3 now seems to be working again.

The remaining failures seem to be related to some robot stuff that don't seem to be related?

@jtpio jtpio mentioned this pull request Jan 8, 2025
@krassowski
Copy link
Member

I'am not sure if I remember how to debug robot failures, but many of these look like changes in language servers, and a few of them might be due to changes in newer lab versions. Certainly can be addressed separately :)

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krassowski krassowski merged commit f5d2b9e into jupyter-lsp:main Jan 9, 2025
8 of 15 checks passed
@jtpio jtpio deleted the fix-ci branch January 9, 2025 09:30
@jtpio
Copy link
Member Author

jtpio commented Jan 9, 2025

I'am not sure if I remember how to debug robot failures, but many of these look like changes in language servers, and a few of them might be due to changes in newer lab versions. Certainly can be addressed separately :)

If we want to have jupyterlab-lsp be a bit closer to JupyterLab (jupyterlab/frontends-team-compass#67), maybe we could consider switching to Playwright / Galata, since this is what all other lab projects are using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants