Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround issue with markdown lost on edit #1016

Merged
merged 4 commits into from
Nov 25, 2023
Merged

Workaround issue with markdown lost on edit #1016

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
93e7797
Resolve traitlets type warnings, lint, remove `six`
krassowski Nov 20, 2023
d6d13ac
Workaround issue with markdown lost on edit
krassowski Nov 20, 2023
75015f9
Merge branch 'main' into fix-edits-markdown
krassowski Nov 25, 2023
359abc6
Merge branch 'main' into fix-edits-markdown
krassowski Nov 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/jupyterlab-lsp/src/edits.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,14 @@ export class EditApplicator {
if (!editor) {
throw Error('Editor is not accessible');
}
if (editor.host.closest('.jp-MarkdownCell')) {
// Workaround for https://github.com/jupyter-lsp/jupyterlab-lsp/issues/1008
// briefly, the rewrite for JupyterLab 4.0 added Markdown cell support, but they
// are extracted without trace in the top-level document. Here we avoid editing
// any markdown cell. Instead the clean solution would be to add an anchor marker
// to the top-level document.
return 0;
}
// TODO: should accessor present the model even if editor is not created yet?
const model = editor.model;

Expand Down