Don't test for cursor position on mousemove if the widget adapter i…

…s not connected (#1114) * Noisy log message Fixes #1113 * Add changelog entry * Lint and remove duplicate --------- Co-authored-by: Frédéric Collonval <[email protected]>
jupyter-lsp · Jan 14, 2025 · b2eb9b1 · b2eb9b1
1 parent f5d2b9e
commit b2eb9b1
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 30 deletions.
diff --git a/.github/workflows/job.test.yml b/.github/workflows/job.test.yml
@@ -62,7 +62,7 @@ jobs:
         uses: conda-incubator/setup-miniconda@v3
         with:
           environment-file: requirements/github-actions.yml
-          mamba-version: "*"
+          mamba-version: '*'
           channels: conda-forge,nodefaults
           channel-priority: true
 
@@ -138,7 +138,7 @@ jobs:
       - name: Set up Python and mamba
         uses: conda-incubator/setup-miniconda@v3
         with:
-          mamba-version: "*"
+          mamba-version: '*'
           channels: conda-forge,nodefaults
           channel-priority: true
 
@@ -239,7 +239,7 @@ jobs:
         with:
           python-version: ${{ matrix.python }}
           environment-file: requirements/github-actions.yml
-          mamba-version: "*"
+          mamba-version: '*'
           channels: conda-forge,nodefaults
           channel-priority: true
 

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 ## Changelog
 
+### `@jupyter-lsp/jupyterlab-lsp (next)`
+
+- bug fixes:
+  - Don't look at editor under the mouse on mouse motion when the widget adapter is not connected ([#1113](https://github.com/jupyter-lsp/jupyterlab-lsp/issues/1113))
+
 ### `jupyter-lsp 2.2.5`
 
 - bug fixes:

diff --git a/packages/jupyterlab-lsp/src/features/hover.ts b/packages/jupyterlab-lsp/src/features/hover.ts
@@ -194,6 +194,10 @@ export class HoverFeature extends Feature {
         });
         const eventListeners = EditorView.domEventHandlers({
           mousemove: event => {
+            // Bail early if the adapter is not connected - and therefore no tooltip can be displayed
+            if (!adapter.isConnected) {
+              return;
+            }
             // this is used to hide the tooltip on leaving cells in notebook
             this.updateUnderlineAndTooltip(event, adapter)
               ?.then(keepTooltip => {

diff --git a/yarn.lock b/yarn.lock
@@ -16799,20 +16799,13 @@ __metadata:
   languageName: node
   linkType: hard
 
-"vscode-jsonrpc@npm:8.0.2, vscode-jsonrpc@npm:^8.0.2":
+"vscode-jsonrpc@npm:8.0.2":
   version: 8.0.2
   resolution: "vscode-jsonrpc@npm:8.0.2"
   checksum: 9d055fd4c87ef1093b0eecb5370bfaf3402179b6639149b6d0f7e0bde60cf580091c7e07b0caff868f10f90331b17e7383c087217c077fdd1b5ae7bc23b72f77
   languageName: node
   linkType: hard
 
-"vscode-jsonrpc@npm:8.2.0":
-  version: 8.2.0
-  resolution: "vscode-jsonrpc@npm:8.2.0"
-  checksum: f302a01e59272adc1ae6494581fa31c15499f9278df76366e3b97b2236c7c53ebfc71efbace9041cfd2caa7f91675b9e56f2407871a1b3c7f760a2e2ee61484a
-  languageName: node
-  linkType: hard
-
 "vscode-jsonrpc@npm:^4.0.0":
   version: 4.0.0
   resolution: "vscode-jsonrpc@npm:4.0.0"
@@ -16827,6 +16820,13 @@ __metadata:
   languageName: node
   linkType: hard
 
+"vscode-jsonrpc@npm:^8.0.2":
+  version: 8.2.0
+  resolution: "vscode-jsonrpc@npm:8.2.0"
+  checksum: f302a01e59272adc1ae6494581fa31c15499f9278df76366e3b97b2236c7c53ebfc71efbace9041cfd2caa7f91675b9e56f2407871a1b3c7f760a2e2ee61484a
+  languageName: node
+  linkType: hard
+
 "vscode-languageclient@npm:^6.1.3":
   version: 6.1.4
   resolution: "vscode-languageclient@npm:6.1.4"
@@ -16887,7 +16887,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"vscode-languageserver-protocol@npm:3.17.2, vscode-languageserver-protocol@npm:^3.10.3, vscode-languageserver-protocol@npm:^3.15.3, vscode-languageserver-protocol@npm:^3.17.0, vscode-languageserver-protocol@npm:^3.7.2":
+"vscode-languageserver-protocol@npm:3.17.2, vscode-languageserver-protocol@npm:^3.10.3, vscode-languageserver-protocol@npm:^3.15.0, vscode-languageserver-protocol@npm:^3.15.3, vscode-languageserver-protocol@npm:^3.17.0, vscode-languageserver-protocol@npm:^3.7.2":
   version: 3.17.2
   resolution: "vscode-languageserver-protocol@npm:3.17.2"
   dependencies:
@@ -16907,16 +16907,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"vscode-languageserver-protocol@npm:^3.15.0":
-  version: 3.17.5
-  resolution: "vscode-languageserver-protocol@npm:3.17.5"
-  dependencies:
-    vscode-jsonrpc: 8.2.0
-    vscode-languageserver-types: 3.17.5
-  checksum: dfb42d276df5dfea728267885b99872ecff62f6c20448b8539fae71bb196b420f5351c5aca7c1047bf8fb1f89fa94a961dce2bc5bf7e726198f4be0bb86a1e71
-  languageName: node
-  linkType: hard
-
 "vscode-languageserver-textdocument@npm:1.0.8, vscode-languageserver-textdocument@npm:^1.0.1":
   version: 1.0.8
   resolution: "vscode-languageserver-textdocument@npm:1.0.8"
@@ -16966,27 +16956,27 @@ __metadata:
   languageName: node
   linkType: hard
 
-"vscode-languageserver-types@npm:3.17.2, vscode-languageserver-types@npm:^3.13.0, vscode-languageserver-types@npm:^3.16.0, vscode-languageserver-types@npm:^3.17.0-next.3, vscode-languageserver-types@npm:^3.7.2":
+"vscode-languageserver-types@npm:3.17.2":
   version: 3.17.2
   resolution: "vscode-languageserver-types@npm:3.17.2"
   checksum: ef2d862d22f622b64de0f428773d50a5928ec6cdd485960a7564ebe4fd4a3c8bcd956f29eb15bc45a0f353846e62f39f6c764d2ab85ce774b8724411ba84342f
   languageName: node
   linkType: hard
 
-"vscode-languageserver-types@npm:3.17.5":
-  version: 3.17.5
-  resolution: "vscode-languageserver-types@npm:3.17.5"
-  checksum: 79b420e7576398d396579ca3a461c9ed70e78db4403cd28bbdf4d3ed2b66a2b4114031172e51fad49f0baa60a2180132d7cb2ea35aa3157d7af3c325528210ac
-  languageName: node
-  linkType: hard
-
 "vscode-languageserver-types@npm:3.5.0":
   version: 3.5.0
   resolution: "vscode-languageserver-types@npm:3.5.0"
   checksum: 44c859700cfda71b5d3ff1224b5a1df093b39ec6755c8beb12fc76d1fbdb1a4948f55c3a97768356a1cbfb4e3ce66c5e4380e25f66bafcbd2db50277f68ee989
   languageName: node
   linkType: hard
 
+"vscode-languageserver-types@npm:^3.13.0, vscode-languageserver-types@npm:^3.16.0, vscode-languageserver-types@npm:^3.17.0-next.3, vscode-languageserver-types@npm:^3.7.2":
+  version: 3.17.5
+  resolution: "vscode-languageserver-types@npm:3.17.5"
+  checksum: 79b420e7576398d396579ca3a461c9ed70e78db4403cd28bbdf4d3ed2b66a2b4114031172e51fad49f0baa60a2180132d7cb2ea35aa3157d7af3c325528210ac
+  languageName: node
+  linkType: hard
+
 "vscode-languageserver@npm:8.0.0-next.8":
   version: 8.0.0-next.8
   resolution: "vscode-languageserver@npm:8.0.0-next.8"