🚀 Add awesomebar-like UX to launch button
#528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2cf97f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agoose77
commented
Feb 4, 2025
This was referenced Feb 5, 2025
|
That is so slick! |
agoose77
commented
Feb 10, 2025
agoose77
commented
Feb 10, 2025
Comment on lines
+38
to
+45
| const { | ||
| className, | ||
| defaultMessage, | ||
| copiedMessage, | ||
| invalidLinkFallback, | ||
| buildLink, | ||
| copiedMessageDuration, | ||
| } = props; |
There was a problem hiding this comment.
Nothing functional (besides variable aliases) is changed here, just cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #507 by changing the launch button UI to detect the target.
It is motivated by 2i2c-org/infrastructure#5348 in 2i2c's sprint planning.
This feature is intended to bring us closer to a time in which the distinction between JupyterHub and BinderHub becomes increasingly less relevant.
There are some nuances encoded in this UX; we assume that the JupyterHub uses
nbgitpuller. In future, we (2i2c) would like to unify the features of nbgitpuller and mybinder so that the language for addressing contents can be drawn closer together.2025-02-04.16-36-14.mp4
To Do
In future, this feature should probably use a reducer — the business logic already feels more complicated than I would like.