-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified Admonition Titles #12
base: main
Are you sure you want to change the base?
Conversation
So, to be frank, I feel it will be impossible to make this change in https://github.com/executablebooks/MyST-Parser: As discussed in jupyter-book/myst-spec#57, I do think it would be possible with
|
With I would also suggest with So instead of
it could be
or even
the key thing here obviously being terseness of the syntax |
Ok, I didn't understand the different code paths between a fence and a code block on the python/docutils side. For JS there isn't an issue at all. I think that really high-grades the colon-fence MEP. Happy to have the colon fence be the documented/only way to do this, the only reason I used backticks here is because that isn't in the myst-spec at all yet. |
Yep, as mentioned in executablebooks/MyST-Parser#713 I feel the key difference here is that:
|
(Happy to jump on a chat to discuss this with you guys 😄 ) |
Note, one thing that is maybe problematic about
e.g. this is not currently valid attribute syntax |
hey @chrisjsewell @rowanc1 I am not sure I fully understand this point / discussion. It would be great to link up at some point to fully explore this. My concern here is that from a user perspective -- they really shouldn't need to know the difference between |
Except, I would suggest, many people do. If we do a quick GitHub search: https://github.com/search?q=%5C%22colon_fence%5C%22&type=code By contrast, and I'm happy to be proved otherwise, I've had very few people ask for what this MEP proposes; and yeh to re-iterate, this MEP is essentially suggesting changing the whole semantics of |
As a random end user stumbling across this let me remark that @chrisjsewell's direction sounds good to me. I had the wish already that anything in a colon fence would be rendered as markdown, period, and never as preformatted code. |
4e6e83b
to
deb4060
Compare
f0715ae
to
548bb07
Compare
51d5d3f
to
123e540
Compare
📖 Read the MEP Here
We propose a simplified syntax to allow arguments for all named admonitions. The syntax allows an argument for any title of a named admonition like
{tip}
or{note}
, to allow users to easily set the color and icon of an admonition while also having a custom title. The proposed syntax is:Coauthored with @mmcky.
See also:
TODO:
MEP0002
!