Fix bad domain naming for model #17381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlm
force-pushed
the
fix-bad-domain-naming
branch
from
4ade78c
to
b5001bd
Compare
hpidcock
approved these changes
May 26, 2024
Previous commits introduced a function called "Get" for getting a model from state. As far as naming convensions go this is a poor choice of names. This commit makes the change to GetModel to be more clear about the purpose of the function.
tlm
force-pushed
the
fix-bad-domain-naming
branch
from
b5001bd
to
be6be01
Compare
Updating modelinfo state interfaces to match the new method definition for model state.
tlm
force-pushed
the
fix-bad-domain-naming
branch
from
be6be01
to
15c4d24
Compare
|
/merge |
2 similar comments
|
/merge |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous commits introduced a function called "Get" for getting a model from state. As far as naming convensions go this is a poor choice of names. This commit makes the change to GetModel to be more clear about the purpose of the function.
Checklist
[ ] Comments saying why design decisions were made[ ] Integration tests, with comments saying what you're testing[ ] doc.go added or updated in changed packagesQA steps
This is just a name change. If unit tests pass and Juju compiles everything is happy.
Documentation changes
N/A