Breaking css minification bug fix: condense_hex_colors breaks 8-digit hex strings #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the regular expression in
condense_hex_colors
to match only 6 digit hex strings using negative look-ahead. Previous behavior would break 8 digit long hex strings, because it would result in an invalid 5 digit hex string. Also added a test file for CSS minification, which contains some tests for hex color minification.Closed the original request and reopened this one since I had made some modifications to the master branch which I didn't intend to include in the pull request, now the changes are in their own branch.